Bug 1425706 - protect from nil tlsConfig. #13073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In very special case (client config does not contain ca cert nor auth cert nor set tls-insecure), tlsConfig can be nil and no error is returned from TLSConfigFor either, thus we need to check for nil on tlsConfig before proceeding in image pruning.
|
LGTM |
|
[test][merge] |
|
Evaluated for origin test up to 32f4837 |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_future/492/) (Image: devenv-rhel7_5968) |
|
Evaluated for origin merge up to 32f4837 |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_future/492/) (Base Commit: cf5b77f) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In very special case (client config does not contain ca cert nor auth cert nor
set tls-insecure), tlsConfig can be nil and no error is returned from TLSConfigFor
either, thus we need to check for nil on tlsConfig before proceeding in
image pruning.
@mfojtik || @pweil- this is the cherry-pick for blocker bug from yesterday ptal: https://bugzilla.redhat.com/show_bug.cgi?id=1425706
The master PR is #13072.