-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Work around docker race condition when running build post commit hooks. #13100
Conversation
👍 I didn't realize we were doing a logs call instead of attach. Makes sense. |
Tested with fork AMI and seems to solve the problem. |
@bparees this should go into release-1.5 as well - does that require a second PR? Once this has merged or concurrently? |
yes it needs a second pr against the release-1.5 branch, concurrent is fine. |
[testextended][extended:core(builds)] |
[test] |
@jim-minter failure looks legitimate. |
(or the merge queue is broken) |
merge tag removed, this breaks an extended test. |
Yes, sorry, repushed and hopefully fixed. Let's see the test results. Ditto on #13196. |
@jim-minter I think the extended tests are still going to fail. |
Evaluated for origin testextended up to e97d96b |
Evaluated for origin test up to e97d96b |
continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_future/795/) (Base Commit: ad8ea70) |
flake #13068 |
continuous-integration/openshift-jenkins/testextended SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin_extended/1151/) (Base Commit: ad8ea70) (Extended Tests: core(builds)) |
[merge] |
flake #13234 |
Evaluated for origin merge up to e97d96b |
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_future/828/) (Base Commit: 8b1ddd5) (Image: devenv-rhel7_6035) |
https://bugzilla.redhat.com/show_bug.cgi?id=1425824