Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UPSTREAM: 41366: Change default reconciler sync period to 1 minute #13132

Merged
merged 2 commits into from
Mar 1, 2017
Merged

UPSTREAM: 41366: Change default reconciler sync period to 1 minute #13132

merged 2 commits into from
Mar 1, 2017

Conversation

mfojtik
Copy link
Contributor

@mfojtik mfojtik commented Feb 28, 2017

Ref: #13025

@mfojtik
Copy link
Contributor Author

mfojtik commented Feb 28, 2017

[test]

@pweil- pweil- mentioned this pull request Feb 28, 2017
Closed
20 tasks
@mfojtik
Copy link
Contributor Author

mfojtik commented Feb 28, 2017

@smarterclayton 👍 or 👎 for 1.5?

@soltysh
Copy link
Contributor

soltysh commented Feb 28, 2017

@mfojtik you need to update defaults test:

--- FAIL: TestCMServerDefaults (0.00s)
06:12:58 	master_config_test.go:156: expected defaults, actual defaults: 
06:12:58 		
06:12:58 		object.KubeControllerManagerConfiguration.ReconcilerSyncLoopPeriod.Duration:
06:12:58 		  a: 5000000000
06:12:58 		  b: 60000000000
06:12:58 	master_config_test.go:157: Got different defaults than expected, adjust in BuildKubernetesMasterConfig and update expectedDefaults

@mfojtik
Copy link
Contributor Author

mfojtik commented Feb 28, 2017

@soltysh just pushed the fix.

@mfojtik
Copy link
Contributor Author

mfojtik commented Feb 28, 2017

flake: #13050

[test]

@smarterclayton
Copy link
Contributor

@openshift/storage needs to weigh in, i thought the argument was for but it's been a while.

@mfojtik
Copy link
Contributor Author

mfojtik commented Mar 1, 2017

@jsafrane any concerns?

@mfojtik
Copy link
Contributor Author

mfojtik commented Mar 1, 2017

[test]

@jsafrane
Copy link
Contributor

jsafrane commented Mar 1, 2017

lgtm

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to a86e3f6

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_future/661/) (Base Commit: 6bd3f30)

1 similar comment
@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_future/661/) (Base Commit: 6bd3f30)

@jsafrane
Copy link
Contributor

jsafrane commented Mar 1, 2017

[merge]

1 similar comment
@mfojtik
Copy link
Contributor Author

mfojtik commented Mar 1, 2017

[merge]

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 1, 2017 •
edited
Loading

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_future/661/) (Image: devenv-rhel7_6004)

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to a86e3f6

@openshift-bot openshift-bot merged commit 9cdd550 into openshift:release-1.5 Mar 1, 2017
@mfojtik mfojtik deleted the upstream-reconciler-period-15 branch September 5, 2018 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mfojtik @soltysh @smarterclayton @jsafrane @openshift-bot