Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider recorder to attach detach controller #13150

Merged
merged 1 commit into from
Mar 1, 2017

Conversation

rootfs
Copy link
Member

@rootfs rootfs commented Feb 28, 2017

@childsb
Copy link
Contributor

childsb commented Feb 28, 2017

[test]

1 similar comment
@jsafrane
Copy link
Contributor

jsafrane commented Mar 1, 2017

[test]

@jsafrane
Copy link
Contributor

jsafrane commented Mar 1, 2017

@rootfs, please follow commit guidelines and add UPSTREAM: xyz to the commit message.

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 2547fed

@jsafrane
Copy link
Contributor

jsafrane commented Mar 1, 2017

oops, sorry, it's OpenShift master, not vendor/kubernetes master...

@jsafrane
Copy link
Contributor

jsafrane commented Mar 1, 2017

@rootfs, we need also PR against origin/master so it's fixed in 1.6.

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_future/657/) (Base Commit: dab42b6)

@jsafrane
Copy link
Contributor

jsafrane commented Mar 1, 2017

[merge]

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 1, 2017

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_future/657/) (Image: devenv-rhel7_6004)

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 2547fed

@openshift-bot openshift-bot merged commit 391ba8b into openshift:release-1.5 Mar 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants