Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPSTREAM: 42275: discovery restmapping should always prefer /v1 #13152

Merged
merged 1 commit into from
Mar 2, 2017

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Feb 28, 2017

@enj upstream pick of the restmapping fix for the authorization pull.

Try picking this into your branch and seeing if it works. I'll merge on lgtm upstream.

@deads2k
Copy link
Contributor Author

deads2k commented Feb 28, 2017

[test]

@enj
Copy link
Contributor

enj commented Feb 28, 2017

Looks good now:

With subjectaccessreviews we get unversioned.GroupResource{Group:"", Resource:"subjectaccessreviews"} + .WithVersion("") + mapper.ResourceFor-> unversioned.GroupVersionResource{Group:"", Version:"v1", Resource:"subjectaccessreviews"}

@deads2k deads2k force-pushed the cli-03-restmapping branch from 56f9408 to 2896536 Compare March 1, 2017 15:55
@deads2k
Copy link
Contributor Author

deads2k commented Mar 1, 2017

lgtm'ed upstream [merge]

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 2896536

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 2896536

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_future/682/) (Base Commit: 3e0d8bb)

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 2, 2017

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_future/764/) (Base Commit: 8eafae6) (Image: devenv-rhel7_6020)

@openshift-bot openshift-bot merged commit e019eb7 into openshift:master Mar 2, 2017
@deads2k deads2k deleted the cli-03-restmapping branch August 3, 2017 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants