Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick for vsphere patches #13159

Merged
merged 7 commits into from
Mar 10, 2017
Merged

Conversation

erinboyd
Copy link

Cherry pick for various vsphere patches to fix panic:
UPSTREAM: 39751: Changed default scsi controller type
UPSTREAM: 39752: Fix panic in vSphere cloud provider
UPSTREAM: 39754: Fix fsGroup to vSphere
UPSTREAM: 39757: Fix space in volumePath in vSphere
UPSTREAM: 40693: fix for vSphere DeleteVolume
UPSTREAM: 41217: Fix wrong VM name is retrieved by the vSphere Cloud Provider
UPSTREAM: 41226: Fix for detach volume when node is not present/ powered off

@erinboyd
Copy link
Author

@eparis @childsb

@wongma7
Copy link
Contributor

wongma7 commented Mar 8, 2017

build is failing 'cause there is a missing colon in the second commit

UPSTREAM: 39752 Fix panic in vSphere cloud provider
UPSTREAM: 39752: Fix panic in vSphere cloud provider

@erinboyd
Copy link
Author

erinboyd commented Mar 8, 2017

@wongma7 fixed!

@gnufied
Copy link
Member

gnufied commented Mar 8, 2017

[test]

@gnufied
Copy link
Member

gnufied commented Mar 8, 2017

Okay I have gone back and looked over the commits in both cloudprovider/vsphere and volume/vsphere_volume and I think we have everything we need. @erinboyd confirms provisioning works now.

So def. lgtm to me.

/lgtm

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 6607d12

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/42/) (Base Commit: fb1f660)

@childsb
Copy link
Contributor

childsb commented Mar 10, 2017

[merge]

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 6607d12

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 10, 2017

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/38/) (Base Commit: fedfdff) (Image: devenv-rhel7_6064)

@openshift-bot openshift-bot merged commit d49d401 into openshift:master Mar 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants