allow build request override of pipeline strategy envs #13160
Conversation
|
we should probably have a test that covers this. (I suspect we do have ones that cover the other strategies already). |
|
On Tue, Feb 28, 2017 at 5:58 PM Ben Parees ***@***.***> wrote:
we should probably have a test that covers this. (I suspect we do have
ones that cover the other strategies already).
my initial scan for existing tests for the other strategies came up empty;
i will make another attempt tomorrow
… —
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#13160 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADbadI5sboe6B1z-wjmjYa-KH8--TG36ks5rhKZ9gaJpZM4MO_lQ>
.
|
|
yeah it looks like this might be the only one: https://github.com/openshift/origin/blob/master/test/extended/builds/start.go#L54 i had expected to see tests here: i think that would be the right place to add new ones. |
gabemontero
force-pushed
the
overridePipelineBCEnvs
branch
from
5a6db06 to
70bc0dd
Compare
|
generator_test.go unit tests for envs pushed |
|
lgtm |
|
flake #12923 |
|
[test] |
|
there was a devicemapper flake note, but also a go vet issue from my change: pkg/build/generator/generator_test.go:552: wrong number of args for format in Errorf call: 2 needed but 3 args will submit change shortly |
|
make verify go-vet check passing locally for me .. pushed update |
gabemontero
force-pushed
the
overridePipelineBCEnvs
branch
from
70bc0dd to
c4d352a
Compare
|
Evaluated for origin test up to c4d352a |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_future/774/) (Base Commit: 1a03d2f) |
|
[merge] |
|
Evaluated for origin merge up to c4d352a |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_future/808/) (Base Commit: ad8ea70) (Image: devenv-rhel7_6029) |
@openshift/devex fyi