cluster up: warn on error parsing Docker version #13201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest version of Docker for Mac/Windows uses the Community Edition versioning scheme. This causes 'cluster up' to halt with an error because the new version cannot be parsed by the 'semver' library. This commit changes the behavior to display a warning instead of exiting with an error.
|
@openshift/devex |
|
lgtm |
|
[merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_future/755/) (Image: devenv-rhel7_6027) |
|
Evaluated for origin merge up to b6fbeef |
|
[Test]ing while waiting on the merge queue |
|
Evaluated for origin test up to b6fbeef |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_future/755/) (Base Commit: f4ef957) |
|
Fix verified... |
This was referenced Mar 6, 2017
|
This worked for me, I'm using Docker for Mac. Has it made into a release yet? Are we gonna have to wait for 1.6.0 or it will make it into next 1.5.x? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest version of Docker for Mac/Windows uses the Community Edition
versioning scheme. This causes 'cluster up' to halt with an error because
the new version cannot be parsed by the 'semver' library. This commit
changes the behavior to display a warning instead of exiting with an
error.
Fixes #13202