Provide configmap for extensions api server authentication #13217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[test] |
…g loopback authenticator
|
Evaluated for origin test up to de5e93b |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_future/815/) (Base Commit: dd3fe18) |
|
Seems a bit hacky... but code LGTM. |
|
[merge] |
|
Evaluated for origin merge up to de5e93b |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_future/851/) (Base Commit: 2261a32) (Image: devenv-rhel7_6039) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This picks a 1.6 change that provides authentication configuration to extension API servers inside of a configmap in kube-system. I had to add a drop commit to the kube post starthook implementation to wait until the loopback client config had permissions to call the post start hooks since its it can take a while on the current level of openshift.
@enj ptal.