UPSTREAM: 42491: make the system:authenticated group adder smarter #13247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d cause error" This reverts commit 76db97a.
|
[test] |
|
re[test] |
|
[test] |
deads2k
force-pushed
the
auth-03-proxy-groups
branch
from
3bb73c7 to
0818506
Compare
deads2k
force-pushed
the
auth-03-proxy-groups
branch
from
0818506 to
6e20c55
Compare
|
Evaluated for origin test up to 6e20c55 |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_future/905/) (Base Commit: 192e57e) |
|
LGTM. |
|
[merge] |
|
Evaluated for origin merge up to 6e20c55 |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_future/929/) (Base Commit: 93efd9b) (Image: devenv-rhel7_6052) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The larger change didn't make 1.6, but the smaller change did. Revert the big one, use the little one.
@enj ptal