Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cookies for reencrypt routes with InsecureEdgeTerminationPolicy " Allow #13250

Merged

Conversation

JacobTanenbaum
Copy link
Contributor

This is a backport of origin PR 13221

currently secure cookies are always generated for reencrypt routes this changes
that to correctly create unsecured cookies when InsecureEdgeTermination policy is
"Allow"

Bug 1428720

…Allow"

currently secure cookies are always generated for reencrypt routes this changes
that to correctly create unsecured cookies when InsecureEdgeTermination policy is
"Allow"

Bug 1428720
@JacobTanenbaum
Copy link
Contributor Author

@knobunc

Copy link
Contributor

@knobunc knobunc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@knobunc
Copy link
Contributor

knobunc commented Mar 6, 2017

[test]

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to c93c368

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_future/861/) (Base Commit: a7dfbda)

@knobunc
Copy link
Contributor

knobunc commented Mar 6, 2017

[merge]

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 6, 2017

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_future/861/) (Base Commit: a7dfbda) (Image: devenv-rhel7_6043)

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to c93c368

@openshift-bot openshift-bot merged commit 788e4d1 into openshift:release-1.5 Mar 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants