UPSTREAM: 38925: Fix nil pointer issue when making mounts for container #13269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, can you apply to 1.5 as well (I assume this needs to be 3.5.x) |
smarterclayton
added
vendor-update
|
[merge] |
|
Evaluated for origin merge up to 7005c14 |
|
[Test]ing while waiting on the merge queue |
|
Evaluated for origin test up to 7005c14 |
|
continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_future/889/) (Base Commit: da719a3) |
|
Idling flake, [merge]
…On Mon, Mar 6, 2017 at 11:21 PM, OpenShift Bot ***@***.***> wrote:
continuous-integration/openshift-jenkins/test FAILURE (
https://ci.openshift.redhat.com/jenkins/job/test_pull_
requests_origin_future/889/) (Base Commit: da719a3
<da719a3>
)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#13269 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABG_p2o80IpgpPP0lr-BXIzMjQtG4Swhks5rjNtEgaJpZM4MU9J5>
.
|
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_future/890/) (Base Commit: 1a2cfff) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13263
Upstream (not yet merged):
kubernetes/kubernetes#38925
Related:
kubernetes/kubernetes#34251
Currently, there exists a gap in the kubelet state where the
vol.Mountercan benil. This was somewhat addressed by kubernetes/kubernetes#33616 but even upstream is still seeing the gap.Simple check to protect against it is the previously excepted solution.
@smarterclayton @derekwaynecarr