Extended tests should store their dependent fixture data in bindata #13361
Conversation
|
@stevekuznetsov this may have problems, since we have some hygiene problems with our fixture data. Not everything is going to play well here, especially things that do docker builds. |
smarterclayton
force-pushed
the
more_bindata
branch
2 times, most recently
from
b1d6214 to
ba8d905
Compare
|
Looks like this is working - we won't get kube e2e though until 1.6 rebase lands. @bparees because your tests pull in a lot of stuff |
smarterclayton
force-pushed
the
more_bindata
branch
from
ba8d905 to
eaae39c
Compare
|
looks reasonable to me, but what's the motivation? making the extended test execution more self-contained? |
|
So you can run e2e tests from the rpm built binary. Kube is doing this as
well, but eventually you just e2e test from this.
I'm going to move test-cmd into this as wel.
On Mar 12, 2017, at 11:29 PM, OpenShift Bot <[email protected]> wrote:
continuous-integration/openshift-jenkins/testextended Running (
https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin_extended/13/)
(Base Commit: 18b1328
<18b1328>)
(Extended Tests: core(builds))
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#13361 (comment)>,
or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABG_p9jtrrTSXJFlCd8jXsN8rvMRhnZyks5rlLgSgaJpZM4MaqAH>
.
|
|
@bparees we want to be able to ship actually functional tests in the |
smarterclayton
force-pushed
the
more_bindata
branch
3 times, most recently
from
d637347 to
e853240
Compare
|
I've fixed all the normal build problems, any other comments @stevekuznetsov or @bparees or @csrwng ? Once the image_ecosystem tests run I'm going to merge this and then advise people on how to fix. |
|
[testextended][extended:core(image_ecosystem)] |
|
LGTM |
|
Green. Will merge tomorrow unless other comments. |
|
[merge] |
smarterclayton
force-pushed
the
more_bindata
branch
from
e853240 to
c04398d
Compare
|
[merge] |
2 similar comments
|
[merge] |
|
[merge] |
Test was incorrectly inverted
Remove EXTENDED_TEST_PATH
smarterclayton
force-pushed
the
more_bindata
branch
from
c04398d to
42deef1
Compare
|
Evaluated for origin test up to 8d3c201 |
|
Evaluated for origin testextended up to 8d3c201 |
|
continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/303/) (Base Commit: b9dbbff) |
|
continuous-integration/openshift-jenkins/testextended SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin_extended/55/) (Base Commit: b9dbbff) (Extended Tests: core(image_ecosystem)) |
|
ActivateDevice flake [merge] |
|
Evaluated for origin merge up to 8d3c201 |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/145/) (Base Commit: b9dbbff) (Image: devenv-rhel7_6087) |
smarterclayton
changed the title
To make it easier to use the extended test suites generated by the RPM, we now create a bootstrap file for extended tests that contains all the fixture data needed to run the tests. The
EXTENDED_TEST_PATHvariable is no longer respected.All fixtures in
test/extended/testdataand some inexamplesare added automatically when you runhack/update-generated-bindata.sh. To access a fixture, use theFixturePath(path)accessor inside of the test utility framework, which will copy the file to disk and give you the path.Be careful about what you add to the fixtures in terms of size, since it will be checked in to the repo and then generated to all binaries.