UPSTREAM: 41436: Fix bug in status manager TerminatePod #13377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#12994 did not merge prior to the 1.5 cut, and we should have this fix before we ship. |
|
[merge] |
|
[test] |
|
Evaluated for origin test up to 0dafa2f |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/170/) (Base Commit: e4200f3) |
|
[merge] some flake about networking |
|
weird, never seen Service latency fail like that. usually it's the start
time.
[merge]
…On Tue, Mar 14, 2017 at 12:45 AM, OpenShift Bot ***@***.***> wrote:
continuous-integration/openshift-jenkins/merge FAILURE (
https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/73/)
(Base Commit: 1404858
<1404858>
)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#13377 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABG_p4nz01g3ZB_OajyjpOVPizQa2xy4ks5rlhtggaJpZM4MbmnU>
.
|
|
another flake re haproxy re [merge] |
|
re [merge] hit #13271 |
|
Evaluated for origin merge up to 0dafa2f |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/86/) (Base Commit: 1404858) (Image: devenv-rhel7_6068) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: kubernetes/kubernetes#41436
In TerminatePod, we previously pass pod.Status to updateStatusInternal. This is a bug, since it is the original status that we are given. Not only does it skip updates made to container statuses, but in some cases it reverted the pod's status to an earlier version, since it was being passed a stale status initially.