Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: fix bulk generator to prefer legacy group #13457

Merged
merged 1 commit into from
Mar 21, 2017
Merged

cli: fix bulk generator to prefer legacy group #13457

merged 1 commit into from
Mar 21, 2017

Conversation

mfojtik
Copy link
Contributor

@mfojtik mfojtik commented Mar 20, 2017 •
edited
Loading

Fixes: #13447

@mfojtik
Copy link
Contributor Author

mfojtik commented Mar 20, 2017

[test]

@csrwng
Copy link
Contributor

csrwng commented Mar 20, 2017

Tested on Mac/RHEL - fixes cluster up for me. Tested new-app, new-build, import-image and they worked as well

@mfojtik
Copy link
Contributor Author

mfojtik commented Mar 20, 2017

@smarterclayton found 3 more places where we need to add this.

@mfojtik
Copy link
Contributor Author

mfojtik commented Mar 20, 2017

add fix for create route command that also used InfoForObject.

@smarterclayton
Copy link
Contributor

Add a test case to verify this doesn't break again?

@mfojtik
Copy link
Contributor Author

mfojtik commented Mar 20, 2017

@smarterclayton test updated to guard that the preferred gvk is not moved.

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to fc69c6f

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/334/) (Base Commit: af801d6)

@smarterclayton
Copy link
Contributor

LGTM [merge]

@smarterclayton
Copy link
Contributor

smarterclayton commented Mar 20, 2017 via email

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to fc69c6f

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 21, 2017 •
edited
Loading

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/156/) (Base Commit: 4a5fb49) (Image: devenv-rhel7_6090)

@openshift-bot openshift-bot merged commit 2988430 into openshift:master Mar 21, 2017
@mfojtik mfojtik deleted the fix-oc branch September 5, 2018 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mfojtik @csrwng @smarterclayton @openshift-bot