Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use correct PEM header #13498

Merged
merged 1 commit into from
Mar 28, 2017
Merged

Use correct PEM header #13498

merged 1 commit into from
Mar 28, 2017

Conversation

liggitt
Copy link
Contributor

@liggitt liggitt commented Mar 22, 2017

PKIX Public Keys use 'PUBLIC KEY' PEM blocks, not 'RSA PUBLIC KEY'

@liggitt
Use correct PEM header
0d71207 
PKIX Public Keys use 'PUBLIC KEY' PEM blocks, not 'RSA PUBLIC KEY'
@liggitt
Copy link
Contributor Author

liggitt commented Mar 22, 2017

[test]

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 0d71207

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/382/) (Base Commit: 65e7463)

@liggitt
Copy link
Contributor Author

liggitt commented Mar 28, 2017

@deads2k @enj PTAL

@enj
Copy link
Contributor

enj commented Mar 28, 2017

PKIX Public Keys use 'PUBLIC KEY' PEM blocks, not 'RSA PUBLIC KEY'

How did this work correctly in the past - did we just ignore the type?

Also, is this backwards compatible?

@liggitt
Copy link
Contributor Author

liggitt commented Mar 28, 2017

did we just ignore the type?

Yes

is this backwards compatible?

Yes. Anything looking at PEM headers was already broken. If we start looking at PEM headers, we'll have to maintain compatibility then

@enj
Copy link
Contributor

enj commented Mar 28, 2017

LGTM 👍 :shipit:

@liggitt
Copy link
Contributor Author

liggitt commented Mar 28, 2017

[merge]

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 0d71207

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 28, 2017 •
edited
Loading

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/216/) (Base Commit: 37a5b46) (Image: devenv-rhel7_6104)

@openshift-bot openshift-bot merged commit 743dfa7 into openshift:master Mar 28, 2017
@liggitt liggitt deleted the public-key-header branch April 7, 2017 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@liggitt @openshift-bot @enj