cluster up: set DNS bind and IP address for newer server versions #13539
Conversation
|
@smarterclayton ptal |
|
[test] |
| } | ||
| if useBindAddress(version) { | ||
| nodeCfg.DNSBindAddress = "127.0.0.1:53" | ||
| nodeCfg.DNSIP = "172.30.0.1" |
There was a problem hiding this comment.
this is really highlighting how problematic the "don't embed an IP" code is. The dns ip should point to the bind address, which then ensures that the code in the node dns is used. That is the long term flow and avoids having to query etcd for endpoints. If we aren't going to use that, we shouldn't start it (don't pass bind address). What happened when only dns ip was set to the service ip?
There was a problem hiding this comment.
So just tried... if I leave the bind address blank and only set the dns ip, then I get the right behavior:
oc rsh simple-ruby-1-48pcf cat /etc/resolv.conf
search default.svc.cluster.local svc.cluster.local cluster.local
nameserver 172.30.0.1
nameserver 192.168.65.1
options ndots:5
I'll change the code to not set the bind address.
There was a problem hiding this comment.
and I don't have to check the version, since the previous versions just ignore the DNSIP
There was a problem hiding this comment.
nm, the previous versions ignore DNSBindAddress ... not DNSIP
csrwng
force-pushed
the
fix_clusterup_dns_bind_ip
branch
from
3fe9b9a to
030fb36
Compare
|
updated the code to not set a bind address |
|
Evaluated for origin test up to 030fb36 |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/458/) (Base Commit: ec459b4) |
|
bump |
|
Lgtm merge at will
On Apr 1, 2017, at 4:24 PM, Cesar Wong <[email protected]> wrote:
bump
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#13539 (comment)>,
or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABG_p-ANP9i11Qf4rYeUcFnkQiQNm8lFks5rrl4EgaJpZM4MouWs>
.
|
|
[merge] |
|
Evaluated for origin merge up to 030fb36 |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/232/) (Base Commit: 645cac4) (Image: devenv-rhel7_6112) |
For origin versions >= 1.5, explicitly set the DNS bind and IP address in the node config.