fix extra lines in new-app output

[gabemontero]

Fixes #13492

Output now:

gmontero ~/go/src/github.com/openshift/origin  (13492)$ oc new-app --template=kube-system/heapster-standalone --dry-run
--> Deploying template "kube-system/heapster-standalone" for "kube-system/heapster-standalone" to project myproject

     Heapster Metrics (Standalone)
     ---------
     A simple metrics solution for an OpenShift cluster. Expects to be installed in the 'kube-system' namespace.

     * With parameters:
        * MASTER_URL=https://kubernetes.default.svc
        * IMAGE_PREFIX=openshift/origin-
        * IMAGE_VERSION=latest
        * METRIC_RESOLUTION=15s
        * STARTUP_TIMEOUT=500
        * NAMESPACE=kube-system

--> Creating resources ...
    serviceaccount "heapster" created (dry run)
    clusterrolebinding "heapster-cluster-reader" created (dry run)
    service "heapster" created (dry run)
    replicationcontroller "heapster" created (dry run)
--> Success (dry run)

[gabemontero]

@openshift/devex @smarterclayton ptal

[bparees]

i don't know that we care that much but this is going to strip out newlines in a string like "foo\n\nbar\n" (ie there's an intentional extra newline in the description and this will strip it).

might be better to just strip all trailing newlines from the string via a regex before doing the split.

[gabemontero]

Seems reasonable to me @bparees

Researching how the existing implementation got where it was, @juanvallejo added the formatString method in #12724 as part of addressing https://bugzilla.redhat.com/show_bug.cgi?id=1370104 for another look and feel complaint against output from the CLI.

Far as I can tell from the comments in those 2 items, there was no explicit intent to strip out newlines from things like "foo\n\nbar\n" ... does that sound right to you @juanvallejo ?

[juanvallejo]

@gabemontero

Far as I can tell from the comments in those 2 items, there was no explicit intent to strip out newlines from things like "foo\n\nbar\n" ... does that sound right to you @juanvallejo ?

Correct, I believe the original approach for formatString only focused on making sure that all new lines in a given string had the same level of indentation

[gabemontero]

thanks @juanvallejo

@bparees - updated change ptal

[bparees]

lgtm [merge]

[gabemontero]

Hit flake #12007 and flake #12060 and flake kubernetes/kubernetes#38573

Those were the three failures during the conformance install run; everything else clean

@bparees please re-post merge comment at your convenience

[bparees]

[merge]

…

On Mon, Mar 27, 2017 at 2:20 PM, Gabe Montero ***@***.***> wrote: Hit flake #12007 <#12007> and flake #12060 <#12060> and flake kubernetes/kubernetes#38573 <kubernetes/kubernetes#38573> Those were the three failures during the conformance install run; everything else clean @bparees <https://github.com/bparees> please re-post merge comment at your convenience — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#13540 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEvl3od47lFICWN8a7TiWw5siubxQ0Twks5rp_3TgaJpZM4Mow77> .

-- Ben Parees | OpenShift

[openshift-bot]

Evaluated for origin merge up to 334cca2

[openshift-bot]

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/208/) (Base Commit: 345cb97) (Image: devenv-rhel7_6104)