deploy: add owner reference to rc from the deployer #13582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[test] |
|
@Kargakis PTAL |
mfojtik
requested review from
ironcladlou and
0xmichalis
and removed request for
ironcladlou
|
lgtm [merge] |
|
[merge] |
|
flake: #13614 |
|
[merge] (fixed fake Patch) |
mfojtik
force-pushed
the
deployer-owner-ref
branch
from
91fcf7f to
3ac9b17
Compare
mfojtik
commented
Apr 5, 2017
| OwnerReferences: []kapi.OwnerReference{{ | ||
| // FIXME: This will have to point to apps.openshift.io/v1 after we switch to | ||
| // clientsets. | ||
| APIVersion: "v1", |
There was a problem hiding this comment.
@Kargakis PTAL again, this has to be set to real version (deployment.APIVersion is internal so no version...).
|
[test] |
|
Evaluated for origin test up to 3ac9b17 |
|
continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/568/) (Base Commit: 801b564) |
|
aws flake [merge] |
|
Evaluated for origin merge up to 3ac9b17 |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/263/) (Base Commit: 83e3250) (Image: devenv-rhel7_6119) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #13554
This will only take effect when the
revisionHistoryis set and there are "failed" deployments. In that case we are keeping the deployer pods (so users can get logs/etc.).