Bug 1435588 - Forbid creating aliases across different Image Streams. #13632
Conversation
|
[test] |
pkg/cmd/cli/cmd/tag.go
Outdated
| }, | ||
| } | ||
|
|
||
| cmd.Flags().StringVar(&opts.sourceKind, "source", opts.sourceKind, "Optional hint for the source type; valid values are 'imagestreamtag', 'istag', 'imagestreamimage', 'isimage', and 'docker'.") | ||
| cmd.Flags().BoolVarP(&opts.deleteTag, "delete", "d", opts.deleteTag, "Delete the provided spec tags.") | ||
| cmd.Flags().BoolVar(&opts.aliasTag, "alias", false, "Should the destination tag be updated whenever the source tag changes. Defaults to false.") | ||
| cmd.Flags().BoolVar(&opts.aliasTag, "alias", false, "Should the destination tag be updated whenever the source tag changes. Applies only to a single Image Stream. Defaults to false.") |
There was a problem hiding this comment.
Maybe we should explain that is only for tags like :latest or :stable, etc.
There was a problem hiding this comment.
I'll do a doc pass after this merges and will explain in details our intentions there.
There was a problem hiding this comment.
Don't capitalize image stream
pkg/cmd/cli/cmd/tag.go
Outdated
| @@ -271,6 +271,25 @@ func (o *TagOptions) Complete(f *clientcmd.Factory, cmd *cobra.Command, args []s | |||
| return nil | |||
| } | |||
|
|
|||
| // Verifies if destination is the same image stream as source. Returns true | |||
There was a problem hiding this comment.
isCrossImageStream verifies
|
LGTM lets wait for the test pass |
|
Previous failure was #13067. |
|
Comments addressed, I don't see any objections so merging as is. [merge] |
|
Evaluated for origin merge up to b3b252a |
|
Evaluated for origin test up to b3b252a |
|
Retroactive lgtm
|
|
continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/583/) (Base Commit: 801b564) |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/261/) (Base Commit: fdd7cc1) (Image: devenv-rhel7_6119) |
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1435588.
As mentioned in #13595 (comment) this PR forbids creating aliases across different Image Streams.
@smarterclayton @mfojtik ptal