Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.5] Fix image pruning with both strong & weak refs #13677

Merged

Conversation

soltysh
Copy link
Contributor

@soltysh soltysh commented Apr 7, 2017

Fix a logic error where an image could incorrectly be considered
prunable if there were both strong and weak references from an image
stream to the image.

1.5 cherrypick of #13671

Fix a logic error where an image could incorrectly be considered
prunable if there were both strong and weak references from an image
stream to the image.
@pweil-
Copy link

pweil- commented Apr 7, 2017

[test]

Copy link

@pweil- pweil- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merging on green

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 09cf32e

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/639/) (Base Commit: 3b55120)

@pweil-
Copy link

pweil- commented Apr 7, 2017

[merge]

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 7, 2017

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/639/) (Base Commit: 3b55120) (Image: devenv-rhel7_6122)

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 09cf32e

@openshift-bot openshift-bot merged commit e935cc6 into openshift:release-1.5 Apr 7, 2017
@soltysh soltysh deleted the 1.5/prune-weak-strong-ref branch April 7, 2017 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants