add reference to build as a label on built images #13703
Conversation
|
@openshift/devex ptal, ultimately this implements the agreement reached here: |
|
[test] |
|
[testextended][extended:core(builds)] |
pkg/build/builder/util.go
Outdated
|
|
||
| // addBuildLabels adds some common image labels describing the build that produced | ||
| // this time. | ||
| func addBuildLabels(labels map[string]string, build *buildapi.Build, labelNamespace string) { |
There was a problem hiding this comment.
why pass the labelNamespace? shouldn't we just use the constant?
There was a problem hiding this comment.
I was trying to keep it generic but yeah in this case i guess there's no real value, i'll change it.
|
LGTM |
| @@ -192,3 +194,10 @@ func reportPushFailure(err error, authPresent bool, pushAuthConfig docker.AuthCo | |||
| } | |||
| return fmt.Errorf("Failed to push image: %v", err) | |||
| } | |||
|
|
|||
| // addBuildLabels adds some common image labels describing the build that produced | |||
There was a problem hiding this comment.
grammar nit: that was produced
There was a problem hiding this comment.
actually it's correct as is. what's incorrect is "this time" on the next line which should read "this image"
|
Evaluated for origin test up to 992b889 |
|
Evaluated for origin testextended up to 992b889 |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/678/) (Base Commit: 1d26c38) |
|
continuous-integration/openshift-jenkins/testextended SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin_extended/144/) (Base Commit: 1d26c38) (Extended Tests: core(builds)) |
|
[merge] |
|
flake #11114 |
|
flake #9414 |
|
Evaluated for origin merge up to 992b889 |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/317/) (Base Commit: b3cacc5) (Image: devenv-rhel7_6134) |
fixes #5978