UPSTREAM: 42275: discovery restmapping should always prefer /v1 #13727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sttts
reviewed
Apr 12, 2017
| @@ -45,6 +45,10 @@ func NewRESTMapper(groupResources []*APIGroupResources, versionInterfaces meta.V | |||
| var resourcePriority []unversioned.GroupVersionResource | |||
There was a problem hiding this comment.
nit: these declaration can be dropped
There was a problem hiding this comment.
i wanted to follow the original commit as close as possible ;-)
sttts
reviewed
Apr 12, 2017
| @@ -45,6 +45,10 @@ func NewRESTMapper(groupResources []*APIGroupResources, versionInterfaces meta.V | |||
| var resourcePriority []unversioned.GroupVersionResource | |||
| var kindPriority []unversioned.GroupVersionKind | |||
|
|
|||
| // /v1 is special. It should always come first | |||
There was a problem hiding this comment.
// new servers will report non-core apigroups for origin resources. Because this client does not know about
// them yet, we enforce that all origin resources resolve to /v1 kinds.
|
Looks good. Two cosmetic comments. |
mfojtik
force-pushed
the
pick-restmapper-fix
branch
from
23d91d4 to
256a705
Compare
|
@sttts comments addressed |
|
[test] |
|
Evaluated for origin test up to 256a705 |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/697/) (Base Commit: efa3fe6) |
|
[merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/697/) (Base Commit: efa3fe6) (Image: devenv-rhel7_6137) |
|
Evaluated for origin merge up to 256a705 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@liggitt @deads2k @sttts PTAL
I tested this manually and it returns the v1.Route object (so describer works as expected).
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1441089