prove the clientbuilder works with RC controller #14033
Conversation
|
[test] |
mfojtik
added
the
approved
|
(approved means we want to get this in during the dcut as we want to fix our controller roles using this approach instead of fiddling the existing bootstrap policy) |
deads2k
force-pushed
the
auth-13-client-builder
branch
2 times, most recently
from
c13c564 to
aa4563b
Compare
deads2k
force-pushed
the
auth-13-client-builder
branch
from
aa4563b to
d700ea8
Compare
deads2k
force-pushed
the
auth-13-client-builder
branch
from
d700ea8 to
8d0fa1c
Compare
openshift-bot
added
the
needs-rebase
deads2k
force-pushed
the
auth-13-client-builder
branch
from
8d0fa1c to
3928ecb
Compare
openshift-bot
removed
the
needs-rebase
|
bump |
| ) | ||
| } | ||
|
|
||
| // GetDeadClusterRoles returns |
There was a problem hiding this comment.
returns dead cluster roles?
There was a problem hiding this comment.
returns dead cluster roles?
Fixed
|
LGTM @deads2k guess the next step is to migrate over rest of the upstream controllers? |
Yes. In progress as we speak |
deads2k
force-pushed
the
auth-13-client-builder
branch
from
3928ecb to
ba8eba7
Compare
|
[merge] |
|
Evaluated for origin merge up to ba8eba7 |
|
Evaluated for origin test up to ba8eba7 |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/1306/) (Base Commit: 31caa0d) |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/602/) (Base Commit: 2d26eae) (Image: devenv-rhel7_6225) |
This pull plumbs in the client builder and controller initializer to our kube launch to start using the upstream roles and bindings.
@liggitt fyi
@enj please review