Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UPSTREAM: 43396: iSCSI CHAP support #14112

Merged
merged 2 commits into from
May 13, 2017
Merged

UPSTREAM: 43396: iSCSI CHAP support #14112

merged 2 commits into from
May 13, 2017

Conversation

rootfs
Copy link
Member

@rootfs rootfs commented May 9, 2017

No description provided.

@rootfs rootfs changed the title [WIP] UPSTREAM: 43396: iSCSI CHAP support UPSTREAM: 43396: iSCSI CHAP support May 11, 2017
@rootfs
Copy link
Member Author

rootfs commented May 11, 2017

@sttts can you take a look? thanks!

@rootfs
Copy link
Member Author

rootfs commented May 11, 2017

[test]

@sttts
Copy link
Contributor

sttts commented May 12, 2017

@rootfs as far as I can judge (am not in the storage code very much) this looks good

@rootfs
generated file
4f484e2 
Signed-off-by: Huamin Chen <[email protected]>
@rootfs
Copy link
Member Author

rootfs commented May 12, 2017

[test]

@rootfs
Copy link
Member Author

rootfs commented May 12, 2017

thanks @sttts !

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 4f484e2

@childsb
Copy link
Contributor

childsb commented May 12, 2017

[merge]

@rootfs
Copy link
Member Author

rootfs commented May 12, 2017

FLAKE #14172

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 4f484e2

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/1397/) (Base Commit: f24a57f)

@rootfs
Copy link
Member Author

rootfs commented May 12, 2017

FLAKE ##14161

@openshift-bot
Copy link
Contributor

openshift-bot commented May 13, 2017 •
edited
Loading

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/638/) (Base Commit: 5977d2d) (Image: devenv-rhel7_6228)

@openshift-bot openshift-bot merged commit 6102ccc into openshift:master May 13, 2017
@liggitt
Copy link
Contributor

liggitt commented Jun 12, 2017

this picked API changes and did not update generated deep copies, defaulting, or conversions. that means the API changes picked in are non-functional. We have to include tests that exercise picked function to ensure that it behaves as expected.

@liggitt liggitt mentioned this pull request Jun 12, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rootfs @sttts @openshift-bot @childsb @liggitt