UPSTREAM: Attach/detach PV bug fixes #14119
Conversation
|
[test] |
| // return | ||
| // } | ||
| if !kcache.WaitForCacheSync(stopCh, adc.podsSynced, adc.nodesSynced, adc.pvcsSynced, adc.pvsSynced) { | ||
| return |
There was a problem hiding this comment.
I thought there should be some error logged here if this fails. no?
There was a problem hiding this comment.
no, absent from upstream too. There will at least be an unexpected "Shutting down attach detach controller". Anyway I think if it failed something catastrophic would have had to happened to controller-manager
There was a problem hiding this comment.
shoot, I just realized you are right about this, it wouldn't hurt to have runtime.HandleError(fmt.Errorf("timed out waiting for caches to sync")) here. Should I add it now since merge failed? :)
edit: nvm, like I said earlier it would have to be some catastrophic stuff happening for it to matter...I only realized this because of the upstream 1.6 cherry-pick
There was a problem hiding this comment.
k whatever I just went ahead and added it since tests keep failing, it's in the ose backport so may as well do it here
|
[test] |
1 similar comment
|
[test] |
|
re[test] needed, flake here: #14110 |
|
[merge] |
|
continuous-integration/openshift-jenkins/merge Waiting: You are in the build queue at position: 6 |
|
2017-05-10T21:01:17.042425000Z Error removing intermediate container c98a0f6d1a9d: Driver devicemapper failed to remove root filesystem c98a0f6d1a9dc4262e41fd7ee496262f2a47d834704f62023dda669fdb82305f: failed to remove device 4c10136014d710097d4fd458e6b1d530b70d255b1614a8187544633023bc263d:Device is Busy |
|
[test] |
1 similar comment
|
[test] |
|
[merge] |
1 similar comment
|
[merge] |
|
Evaluated for origin merge up to 0ade7d0 |
|
The test failure revealed a PR we missed, kubernetes/kubernetes#43289 The issue is that it's possible for nodeAdd to fire before dswp is initialized, causing a nil pointer exception. We ought to port kubernetes/kubernetes#44760 over too, working on it |
|
[test] * |
|
Evaluated for origin test up to 8b7ba77 |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/1377/) (Base Commit: f24a57f) |
|
[merge] |
|
[merge]! |
|
This is still at #7 in merge-queue. :( |
|
this already went into 3.5, so i'm going by hand. |
Not all applied cleanly, notably most of 39732's changes to attach_detach_controller.go had to be manually applied I guess because git couldn't figure out the offset. Was not tricky or anything but still needs to be reviewed