Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPSTREAM: 45286: When pods are terminated we should detach the volume #14191

Merged
merged 1 commit into from
May 19, 2017

Conversation

gnufied
Copy link
Member

@gnufied gnufied commented May 15, 2017

@gnufied
Copy link
Member Author

gnufied commented May 15, 2017

[test][merge]

@smarterclayton
Copy link
Contributor

Are there ansible changes planned to set this annotation?

@gnufied
Copy link
Member Author

gnufied commented May 15, 2017

@smarterclayton there are no ansible change necessary to set this annotation. The annotation solely exists to make sure if at all kubelet was started with keep-terminated-pod-volumes option, controller honours it too.

We are going to deprecated that flag. kubernetes/kubernetes#45615
Also by default that flag is not set in kubelet. It was an oversight on our part to introduce such a flag in first place.

@eparis
Copy link
Member

eparis commented May 15, 2017

please don't set the annotation. ever. period. no.

@childsb
Copy link
Contributor

childsb commented May 15, 2017

[merge]

@smarterclayton
Copy link
Contributor

smarterclayton commented May 16, 2017 via email

@eparis
Copy link
Member

eparis commented May 16, 2017

[test] #10773

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 64acaee

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/1509/) (Base Commit: 3949203)

@smarterclayton
Copy link
Contributor

smarterclayton commented May 19, 2017 via email

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 64acaee

@openshift-bot
Copy link
Contributor

openshift-bot commented May 19, 2017

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/707/) (Base Commit: 2ceece1) (Image: devenv-rhel7_6242)

@openshift-bot openshift-bot merged commit 8297c50 into openshift:master May 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants