-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UPSTREAM: 41939: Add an AEAD encrypting transformer for storing secrets encrypted at rest #14243
UPSTREAM: 41939: Add an AEAD encrypting transformer for storing secrets encrypted at rest #14243
Conversation
Why is this a |
Also, can this wait until the next rebase? |
@ncdc it was merged |
@ncdc Because it's already merged in the k8s and will be here after next rebase. |
@ncdc can't wait unfortunately... |
Please don't mark it as a |
@ncdc It's my first backport so I can do something wrong just because don't know how to do it properly. I'd be grateful if you point me to the documentation that describe the process.
How it should be marked then? |
@php-coder |
7a3a55d
to
c5f077f
Compare
@smarterclayton lets sync about this early next week and figure out what is missing and how to wire this into our config. |
We actually want the _test.go files in this case. |
…ts encrypted at rest.
c5f077f
to
248eb53
Compare
Added. |
LGTM [merge] |
Evaluated for origin merge up to 248eb53 |
[Test]ing while waiting on the merge queue |
Evaluated for origin test up to 248eb53 |
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/1564/) (Base Commit: 74e1a68) |
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/722/) (Base Commit: 932e9dd) (Image: devenv-rhel7_6247) |
Backport of kubernetes/kubernetes#41939
I've excluded
staging/src/k8s.io/apiserver/pkg/storage/etcd3/store_test.go
,staging/src/k8s.io/apiserver/pkg/storage/tests/cacher_test.go
because we don't have them. Alsohack/.linted_packages
andBUILD
files were excluded too, AFIU we don't need them.PTAL @smarterclayton @mfojtik