Kube GC improvements backports #14358
Conversation
… to garbage collector ignore list
Use shared informers for GC if possible Update required verbs for deletable resources Allow list of ignored resources to be customized
|
This seems to work locally. It logged that it was using shared informers for GC where it could. It can't, however, use shared informers for OpenShift resources, because the Kubernetes GarbageController doesn't have access to any shared informers other than those in Kubernetes. We could modify the GC configuration to take in something like type MonitorFactory interface {
MonitorFor(resource schema.GroupResource) (cache.Controller, error)
}and then allow OpenShift to use one of its own that knows how to look up shared informers for both Kubernetes and OpenShift resources. Do you think this change is worth doing, given the desire to have OpenShift run on top of Kubernetes? [test] |
|
Given that it probably saves us 20 duplicate informers, I think it's worth
it. If you don't have time to get to it, I will
On May 25, 2017, at 5:06 PM, OpenShift Bot <[email protected]> wrote:
continuous-integration/openshift-jenkins/test Running (
https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/1784/)
(Base Commit: d03a427
<d03a427>
)
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#14358 (comment)>,
or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABG_p6c9BB5oUmv9y8qZNu2Y4_WnLjg0ks5r9e1KgaJpZM4Nmo84>
.
|
|
Tests have a few failures, otherwise LGTM. The MonitorFor we should try to get for 3.6 if we can - we need to get our cache counts down to hit our scale numbers. |
|
@smarterclayton latest commit hopefully fixes the test issues |
|
Worked, was flake. |
|
[merge][severity:blocker] serious performance regression |
|
Evaluated for origin merge up to 73f9c02 |
|
[test] |
|
[test] flake fox was force merged
|
|
Evaluated for origin test up to 73f9c02 |
|
continuous-integration/openshift-jenkins/merge Running (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/826/) (Base Commit: 908f6a0) (Extended Tests: blocker) |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/1814/) (Base Commit: 908f6a0) |
|
Failed due to idler flake, force merging |
Use shared informers for GC if possible
Update required verbs for deletable resources
Allow list of ignored resources to be customized
@smarterclayton @liggitt @deads2k @sttts @mfojtik