UPSTREAM: 44406: CRI: Stop following container log when container exited #14380
Conversation
|
Confirmed this fixes the symptoms I was seeing in #14374 |
|
On Fri, May 26, 2017 at 2:24 PM, Sam Padgett ***@***.***> wrote:
Confirmed this fixes the symptoms I was seeing in #14374
<#14374>
+1
… —
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#14380 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADbadIh_9nZe2iMXMa9JyweLs0uU7fgwks5r9xjmgaJpZM4Nn4G4>
.
|
|
hey @ncdc - the fix here to the uninitiated seems pretty generic ... curious as to why this would only apply to json-file log driver is the container status maintained so differently when using json-file vs. journald that the fix is not needed ... or is this just a timing window that is more prevalent with json-file? thanks |
|
@gabemontero we don't use this code path for journald - see kubernetes/kubernetes#42195. |
|
ah - gotcha - thanks @ncdc |
|
[merge][severity:blocker]
…On Fri, May 26, 2017 at 3:58 PM, Gabe Montero ***@***.***> wrote:
ah - gotcha - thanks @ncdc <https://github.com/ncdc>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#14380 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABG_pwX-QIcxO1i4wQI3_iSeAUSYewTEks5r9y7tgaJpZM4Nn4G4>
.
|
|
Evaluated for origin merge up to 7c8c209 |
|
[Test]ing while waiting on the merge queue |
|
Evaluated for origin test up to 7c8c209 |
|
continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/1810/) (Base Commit: f703da4) |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/831/) (Base Commit: 2b00e78) (Extended Tests: blocker) (Image: devenv-rhel7_6280) |
This only applies when docker's log driver is json-file, which I believe is always the case with docker for mac.
@jwforres @gabemontero @spadgett @smarterclayton @derekwaynecarr @sjenning