-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update aggregator to match latest kube #14676
Conversation
uh. so i need to go update all my cluster up stuff to use v1beta1 instead of v1alpha1? |
@ewolinetz fyi |
And you need |
@deads2k how soon can we get this in the queue? i can't put the cluster up PR in the merge queue until this goes in. |
@deads2k all the generated.pb.go changes with no accompanying descriptor changes are unexpected. what version of go did you run with? (and/or did you clean the built proto-generating tools after switching go versions) (gzip differences will output different gzipped manifests) |
just the question on the generated.pb.go changes, LGTM otherwise |
@liggitt grrrr. Probably 1.8. Just normal kube env. |
reran with 1.7, no changes. [test] |
[merge] |
continuous-integration/openshift-jenkins/merge Waiting: You are in the build queue at position: 12 |
Evaluated for origin merge up to c7463bc |
[test] |
Evaluated for origin test up to 3d93cfb |
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/2304/) (Base Commit: a68db68) (PR Branch Commit: 3d93cfb) |
@smarterclayton green if you're still manually tending |
This updates openshift to use the latest aggregation APIs.
@liggitt I didn't add comments in the existing groups, since we aren't going to have new versions in openshfit for a while.