Fix update rawextension decoding

[liggitt]

We're seeing weird things decoding update requests containing raw extensions... they're not getting converted to the internal version of the runtime object.

xref #14743

[liggitt]

cc @enj @smarterclayton @deads2k

[enj]

So from what I have gathered the issue is that DecodeNestedObjects only has the passed in decoder for decoding, but has no into equivalent for handling conversion. Thus whatever GVK the decoder uses is seen at the REST layer (v1).

if d, ok := obj.(runtime.NestedObjectDecoder); ok {
	if err := d.DecodeNestedObjects(DirectDecoder{c.decoder}); err != nil {
		return nil, gvk, err
	}
}

The outer object is decoded and converted into the GVK of into (the internal type).

obj, gvk, err := c.decoder.Decode(data, defaultGVK, into)
if err != nil {
	return nil, gvk, err
}

if err := c.convertor.Convert(obj, into, c.decodeVersion); err != nil {
	return nil, gvk, err
}

After fixing the compile error in this PR, the update works as expected, though I did see some weird logs:

Convert_v1_PolicyRule_To_api_PolicyRule in:
k8s
#
�v1��IsPersonalSubjectAccessReview��"
&runtime.Unknown{TypeMeta:runtime.TypeMeta{APIVersion:"v1", Kind:"IsPersonalSubjectAccessReview"}, Raw:[]uint8{}, ContentEncoding:"", ContentType:""}
&runtime.Unknown{TypeMeta:runtime.TypeMeta{APIVersion:"v1", Kind:"IsPersonalSubjectAccessReview"}, Raw:[]uint8{}, ContentEncoding:"", ContentType:""}

[smarterclayton]

This is the backwards compatible change I expected

[enj]

LGTM, I assume we want this upstream this as well?

[liggitt]

yeah, kubernetes/kubernetes#47792

[liggitt]

@enj the issue you are seeing is in the streamwatcher. It isn't related to this change, but we'll need to figure out what is going wrong with that area as well, as that can affect other watchers of items containing raw extensions.

[liggitt]

[test]

[openshift-bot]

Evaluated for origin test up to a6c9c12

[openshift-bot]

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/2442/) (Base Commit: df9c0ed) (PR Branch Commit: a6c9c12)

[liggitt]

upstream has LGTM
[merge][severity:blocker]

[openshift-bot]

Evaluated for origin merge up to a6c9c12

[openshift-bot]

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/1079/) (Base Commit: 857cfa5) (PR Branch Commit: a6c9c12) (Extended Tests: blocker) (Image: devenv-rhel7_6392)