ImageStreamTag update should ignore missing labels #15098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we started returning labels for image stream tags, old clients that retrieved the tag and updated the field were broken if the image stream had tags, since they would send empty labels (not having received them via the API) on update, and labels are immutable. This preserves the legacy behavior by defaulting the user provided image stream tag labels to the image stream labels if no labels are set in the image stream tag.
smarterclayton
added
area/compatibility
component/image
kind/bug
|
Supersedes #14803 |
deads2k
reviewed
Jul 7, 2017
| @@ -219,6 +219,12 @@ func (r *REST) Update(ctx apirequest.Context, tagName string, objInfo rest.Updat | |||
| return nil, false, kapierrors.NewConflict(imageapi.Resource("imagestreamtags"), istag.Name, fmt.Errorf("another caller has updated the resource version to %s", imageStream.ResourceVersion)) | |||
| } | |||
|
|
|||
| // When we began returning image stream labels in 3.6, old clients that didn't need to send labels would be | |||
| // broken on update. Explicitly default labels if they are unset. We don't support mutation of labels on update. | |||
There was a problem hiding this comment.
This is ensured by a validator?
There was a problem hiding this comment.
Yeah, old clients were getting immutable errors (because they previously did not need to send labels even if the image stream had them).
|
One question. if it is ensured, then lgtm |
|
[test] |
|
Evaluated for origin test up to 0c65fbb |
|
continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/3026/) (Base Commit: 5c7eff8) (PR Branch Commit: 0c65fbb) |
|
Flake on networking setup, merge |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we started returning labels for image stream tags in 3.6, old clients that
retrieved the tag and updated the field were broken if the image stream
had tags, since they would send empty labels (not having received them
via the API) on update, and labels are immutable.
This preserves the legacy behavior by defaulting the user provided image
stream tag labels to the image stream labels if no labels are set in the
image stream tag.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1463890
[test] @mfojtik @deads2k