Run separate informers for api and controllers #15217
Conversation
|
[severity:blocker] |
|
[test] |
|
@deads2k PTAL |
|
We have users running very large all-in-one setups. Is this going to double memory use? |
|
known flake on "oc rollout status dc/ipfailover" - #14403 |
Not double, the api server doesn't watch all resources. |
|
Will run some tests to get numbers.
On Jul 14, 2017, at 11:07 PM, OpenShift Bot <[email protected]> wrote:
continuous-integration/openshift-jenkins/test FAILURE (
https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/3173/)
(Base Commit: bca9c79
<bca9c79>)
(PR Branch Commit: 6d86bbb
<6d86bbb>
)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#15217 (comment)>,
or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABG_p5getoLG4ijqwd5sLCRMWZFc1FpTks5sOCz6gaJpZM4OYuuC>
.
|
|
Integration setup flake, [test] |
|
Evaluated for origin test up to 6d86bbb |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/3177/) (Base Commit: 987a609) (PR Branch Commit: 6d86bbb) |
|
lgtm, this was on my list and makes logical sense since controllers are late initializing |
|
Ship it, it makes performance worse, but it's only 10-ish unshared informers anyway. |
|
[merge] |
|
Evaluated for origin merge up to 6d86bbb |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/1294/) (Base Commit: 8693402) (PR Branch Commit: 6d86bbb) (Extended Tests: blocker) (Image: devenv-rhel7_6448) |
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1470009