update bootstrappolicy/dead addDeadClusterRole to include systemOnly annotation #15320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…annotation Roles that have been replaced by kube controller roles should receive the systemOnly annotation to ensure they are not visible to typical end users (such as those who would use the web console). - updates bootstrappolicy/dead addDeadClusterRole - updates bootstrappolicy/web_console_role_test TestSystemOnlyRoles - still skips controller roles (maintenance simplicity), but will throw an error if the annotation is missing
|
cherry-pick of #15247 onto 3.6 |
|
[test] |
|
Evaluated for origin test up to f2263f6 |
|
[merge][severity:blocker] |
|
Evaluated for origin merge up to f2263f6 |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/1304/) (Base Commit: 20e72f7) (PR Branch Commit: f2263f6) (Extended Tests: blocker) (Image: devenv-rhel7_6451) |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/3250/) (Base Commit: 20e72f7) (PR Branch Commit: f2263f6) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Roles that have been replaced by kube controller roles should receive
the systemOnly annotation to ensure they are not visible to typical
end users (such as those who would use the web console).