Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.6] Fix issues related to the migration to RBAC and the Kubernetes authorizer #15348

Merged
merged 2 commits into from
Jul 25, 2017
Merged

[3.6] Fix issues related to the migration to RBAC and the Kubernetes authorizer #15348

merged 2 commits into from
Jul 25, 2017

Conversation

enj
Copy link
Contributor

@enj enj commented Jul 19, 2017 •
edited
Loading

Cherry-pick of #15342 into release-3.6

@liggitt PTAL

[test]

enj added 2 commits July 19, 2017 14:24
@enj
Fix conversion for role binding to cluster role
b4a23e3 
This change makes it so that the conversion for authorization
policy correctly handles when a RBAC role binding references a
cluster role.  The code incorrectly assumed that the role binding's
namespace was the referenced role's namespace as well.  Now we use
the role's kind to determine its namespace.  This was missed by the
fuzzer tests because they only made role bindings to roles.  The
tests have been updated to create bindings to both types of roles.

Signed-off-by: Monis Khan <[email protected]>
@enj
Update quota controller's role for Kube authorizer
3e477e4 
This change normalizes the cluster-quota-reconciliation-controller's
bootstrap role so that it will work with the Kubernetes authorizer
which is case sensitive.

Signed-off-by: Monis Khan <[email protected]>
@enj enj changed the title Cherry-pick of #15342 into release-3.6 [3.6] Fix issues related to the migration to RBAC and the Kubernetes authorizer Jul 19, 2017
@liggitt
Copy link
Contributor

liggitt commented Jul 19, 2017

[merge][severity:blocker]

@enj enj added this to the 3.6.0 milestone Jul 19, 2017
@enj
Copy link
Contributor Author

enj commented Jul 20, 2017 

298352003e9e: Download complete
298352003e9e: Pull complete
e5186cffb433: Pull complete
0d1b21a54419: Pull complete
Digest: sha256:7685193b578d85619f3985425fad8b30f050a5318cb8687189e402afabf10470
+ ../../bin/local.sh ansible-playbook -e provision_gce_docker_storage_driver=overlay2 -e openshift_test_repo=https://storage.googleapis.com/origin-ci-test/pr-logs/pull/15348/test_pull_request_origin_extended_conformance_gce/4477/artifacts/rpms playbooks/launch.yaml
Activated service account credentials for: [jenkins-ci-provisioner@openshift-gce-devel.iam.gserviceaccount.com]
ERROR! Attempted to execute "/usr/share/ansible/openshift-ansible-gce/inventory.sh" as inventory script: Inventory script (/usr/share/ansible/openshift-ansible-gce/inventory.sh) had an execution error: Traceback (most recent call last):
  File "/usr/share/ansible/openshift-ansible-gce/inventory/gce/hosts/gce.py", line 400, in <module>
    GceInventory()
  File "/usr/share/ansible/openshift-ansible-gce/inventory/gce/hosts/gce.py", line 132, in __init__
    print(self.json_format_dict(self.group_instances(zones),
  File "/usr/share/ansible/openshift-ansible-gce/inventory/gce/hosts/gce.py", line 320, in group_instances
    nodes = self.driver.list_nodes()
  File "/usr/lib/python2.7/site-packages/libcloud/compute/drivers/gce.py", line 2419, in list_nodes
    use_disk_cache=ex_use_disk_cache)
  File "/usr/lib/python2.7/site-packages/libcloud/compute/drivers/gce.py", line 8366, in _to_node
    bd['name'], bd['zone'], use_cache=use_disk_cache)
  File "/usr/lib/python2.7/site-packages/libcloud/compute/drivers/gce.py", line 7109, in ex_get_volume
    return self._ex_lookup_volume(name, zone)
  File "/usr/lib/python2.7/site-packages/libcloud/compute/drivers/gce.py", line 7405, in _ex_lookup_volume
    self._ex_populate_dict()
AttributeError: 'GCENodeDriver' object has no attribute '_ex_populate_dict'
 
++ export status=FAILURE
++ status=FAILURE
+ set +o xtrace
########## FINISHED STAGE: FAILURE: PROVISION TEST CLUSTER [00h 00m 35s] ##########

@stevekuznetsov @sdodson @jupierce wat?

@stevekuznetsov
Copy link
Contributor

@enj this is our catchall for that I believe

#14575

@enj
Copy link
Contributor Author

enj commented Jul 20, 2017

re[merge] flake #14575

@liggitt
Copy link
Contributor

liggitt commented Jul 21, 2017

[test]

@openshift-merge-robot
Copy link
Contributor

Labelling this PR as size/M

@openshift openshift deleted a comment from openshift-bot Jul 22, 2017
@openshift openshift deleted a comment from openshift-bot Jul 22, 2017
@enj enj mentioned this pull request Jul 22, 2017
Closed
@enj
Copy link
Contributor Author

enj commented Jul 22, 2017

@derekwaynecarr @smarterclayton @liggitt this seems to be broken on #15252

@liggitt
Copy link
Contributor

liggitt commented Jul 22, 2017

#15252 was to reenable tests disabled as part of the rebase. IIRC, those two had just been enabled a couple weeks earlier after having been disabled for being flaky.

Since this is against release-3.6, it's clearly unaffected by the rebase. Were we wrong to enable those tests for 3.6?

@openshift-merge-robot
Copy link
Contributor

Labelling this PR as size/M

@openshift-merge-robot openshift-merge-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 24, 2017
@liggitt
Copy link
Contributor

liggitt commented Jul 24, 2017

[merge][test] GCE PV fix was merged for ansible

@enj
Copy link
Contributor Author

enj commented Jul 25, 2017

Still broken on StatefulSet issues...

@liggitt
Copy link
Contributor

liggitt commented Jul 25, 2017

required an image rebuild/repush, got updated around 5:30pm. [test][merge]

@enj
Copy link
Contributor Author

enj commented Jul 25, 2017

xref openshift/openshift-ansible/pull/4841

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 3e477e4

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 3e477e4

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/3470/) (Base Commit: 7b73dab) (PR Branch Commit: 3e477e4)

@openshift-bot
Copy link
Contributor

openshift-bot commented Jul 25, 2017 •
edited
Loading

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/1375/) (Base Commit: 7b73dab) (PR Branch Commit: 3e477e4) (Extended Tests: blocker) (Image: devenv-rhel7_6479)

@openshift-bot openshift-bot merged commit 7135a3d into openshift:release-3.6 Jul 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
3.6.0
Development

Successfully merging this pull request may close these issues.
5 participants
@enj @liggitt @stevekuznetsov @openshift-merge-robot @openshift-bot