Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an ENV to control ipv6 behavior in the router #15351

Merged

Conversation

knobunc
Copy link
Contributor

@knobunc knobunc commented Jul 19, 2017

This patch adds an environent variable called ROUTER_IP_V4_V6_MODE
which must be set to "v4" (the default), "v6", or "v4v6" to control
whether the router to binds to IPv4, IPv6, or both.

Note that when set to 'v6' or 'v4v6', the X-Forwarded-For and
Forwarded http headers will be in IPv6 form (even when the connection
was an IPv4 one, if set to 'v4v6').

Back-port of #15229

Fixes bug 1472976 (https://bugzilla.redhat.com/show_bug.cgi?id=1472976)

This patch adds an environent variable called ROUTER_IP_V4_V6_MODE
which must be set to "v4" (the default), "v6", or "v4v6" to control
whether the router to binds to IPv4, IPv6, or both.

Note that when set to 'v6' or 'v4v6', the X-Forwarded-For and
Forwarded http headers will be in IPv6 form (even when the connection
was an IPv4 one, if set to 'v4v6').

Back-port of openshift#15229

Fixes bug 1472976 (https://bugzilla.redhat.com/show_bug.cgi?id=1472976)
@knobunc knobunc added this to the 3.6.0 milestone Jul 19, 2017
@knobunc knobunc self-assigned this Jul 19, 2017
@knobunc knobunc requested review from rajatchopra and pecameron July 19, 2017 20:03
@knobunc
Copy link
Contributor Author

knobunc commented Jul 19, 2017

@openshift/networking FYI

@knobunc
Copy link
Contributor Author

knobunc commented Jul 19, 2017

[test][testextended][extended: networking]

@knobunc
Copy link
Contributor Author

knobunc commented Jul 20, 2017

[test] last flaked on #15337
[testextended][extended: networking]

@knobunc
Copy link
Contributor Author

knobunc commented Jul 20, 2017

[merge][severity: blocker]

This has passed each test cleanly... just not on the same run. i.e. each run has flaked in different places.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jul 20, 2017

continuous-integration/openshift-jenkins/merge Waiting: You are in the build queue at position: 3

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 19208a5

@knobunc
Copy link
Contributor Author

knobunc commented Jul 20, 2017

[test] flaked on #15351
[testextended][extended: networking]

@openshift-bot
Copy link
Contributor

Evaluated for origin testextended up to 19208a5

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/testextended SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin_extended/890/) (Base Commit: b7540a5) (PR Branch Commit: 19208a5) (Extended Tests: networking)

@knobunc
Copy link
Contributor Author

knobunc commented Jul 20, 2017

[test] flaked on docker pull with error pulling image configuration: received unexpected HTTP status: 500 Internal Server Error

@liggitt
Copy link
Contributor

liggitt commented Jul 21, 2017

sdnnamespace flake fix merged, [test]

@knobunc
Copy link
Contributor Author

knobunc commented Jul 21, 2017

[test] flaked on #15401

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 19208a5

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test Running (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/3384/) (Base Commit: 787f4e2) (PR Branch Commit: 19208a5)

@smarterclayton smarterclayton merged commit 099ca6b into openshift:release-3.6 Jul 21, 2017
@knobunc knobunc deleted the bug/bz1471255-ipv6-env-3-6 branch July 22, 2017 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants