Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPSTREAM: 49230: use informers for quota calculation #15357

Merged

Conversation

derekwaynecarr
Copy link
Member

@derekwaynecarr derekwaynecarr commented Jul 19, 2017

@derekwaynecarr
Copy link
Member Author

[test]

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to fd5ec6d

@derekwaynecarr derekwaynecarr changed the title WIP: UPSTREAM: 49230: use informers for quota calculation UPSTREAM: 49230: use informers for quota calculation Jul 19, 2017
@derekwaynecarr
Copy link
Member Author

@deads2k - please review.

/cc @eparis @smarterclayton -- assuming we list all the referenced resources in our existing controller, this will improve the responsiveness of resource quota controller with out having a major memory impact. opening this to evaluate for release-3.6 or soon after.

@smarterclayton
Copy link
Contributor

I can't see how this is worse than today, so +1 by me.

@derekwaynecarr
Copy link
Member Author

@smarterclayton - are we listing configmaps today in controllers, that is my only concern right now, but ran out of time to check at moment.

@smarterclayton
Copy link
Contributor

GC lists everything

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/3306/) (Base Commit: 12575c5) (PR Branch Commit: fd5ec6d)

@deads2k
Copy link
Contributor

deads2k commented Jul 20, 2017

I'm assuming it picked clean? If so, lgtm.

@derekwaynecarr
Copy link
Member Author

@deads2k
i had to fixup for older machinery stuff, but yeah, clean for the most part.

[merge][severity:blocker]

@openshift-bot
Copy link
Contributor

openshift-bot commented Jul 20, 2017

continuous-integration/openshift-jenkins/merge Waiting: You are in the build queue at position: 4

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to fd5ec6d

@eparis eparis added this to the 3.6.0 milestone Jul 20, 2017
@smarterclayton smarterclayton merged commit 8a97659 into openshift:release-3.6 Jul 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants