-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UPSTREAM: 49230: use informers for quota calculation #15357
UPSTREAM: 49230: use informers for quota calculation #15357
Conversation
[test] |
Evaluated for origin test up to fd5ec6d |
@deads2k - please review. /cc @eparis @smarterclayton -- assuming we list all the referenced resources in our existing controller, this will improve the responsiveness of resource quota controller with out having a major memory impact. opening this to evaluate for release-3.6 or soon after. |
I can't see how this is worse than today, so +1 by me. |
@smarterclayton - are we listing configmaps today in controllers, that is my only concern right now, but ran out of time to check at moment. |
GC lists everything |
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/3306/) (Base Commit: 12575c5) (PR Branch Commit: fd5ec6d) |
I'm assuming it picked clean? If so, lgtm. |
@deads2k [merge][severity:blocker] |
continuous-integration/openshift-jenkins/merge Waiting: You are in the build queue at position: 4 |
Evaluated for origin merge up to fd5ec6d |
xref: https://bugzilla.redhat.com/show_bug.cgi?id=1473042
bug 1473042
see: kubernetes/kubernetes#49230