Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UPSTREAM: 48940: support fc volume attach and detach #15437

Merged
merged 1 commit into from
Sep 7, 2017
Merged

UPSTREAM: 48940: support fc volume attach and detach #15437

merged 1 commit into from
Sep 7, 2017

Conversation

rootfs
Copy link
Member

@rootfs rootfs commented Jul 24, 2017 •
edited
Loading

@rootfs
UPSTREAM: 48940: support fc volume attach and detach
70111fa 
Signed-off-by: Huamin Chen <[email protected]>

Conflicts:
	vendor/k8s.io/kubernetes/cmd/kube-controller-manager/app/plugins.go
@openshift-merge-robot openshift-merge-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 24, 2017
@rootfs
Copy link
Member Author

rootfs commented Jul 24, 2017

[test]

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 70111fa

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/3456/) (Base Commit: 727639e) (PR Branch Commit: 70111fa)

@bparees
Copy link
Contributor

bparees commented Jul 25, 2017

/assign @eparis

@bparees bparees removed their assignment Jul 25, 2017
@openshift-merge-robot openshift-merge-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 28, 2017
@rootfs
Copy link
Member Author

rootfs commented Jul 31, 2017

@eparis can you approve?

@0xmichalis
Copy link
Contributor

/retest

@childsb
Copy link
Contributor

childsb commented Sep 7, 2017

/approve no-issue

@eparis
Copy link
Member

eparis commented Sep 7, 2017

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 7, 2017
@openshift-merge-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: childsb, eparis, rootfs

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 7, 2017
@rootfs
Copy link
Member Author

rootfs commented Sep 7, 2017 •
edited
Loading

@childsb @eparis can we merge it? I need it to pick up 49416 so we can fix https://bugzilla.redhat.com/show_bug.cgi?id=1473855.

@rootfs
Copy link
Member Author

rootfs commented Sep 7, 2017

cc @mtanino

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue

@openshift-merge-robot openshift-merge-robot merged commit 82ed019 into openshift:master Sep 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@eparis eparis

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@rootfs @openshift-bot @bparees @0xmichalis @childsb @eparis @openshift-merge-robot @openshift-ci-robot