Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump(k8s.io/kubernetes): d2e5420de791a3a5234eb1c3d84921d68ae2b6d6 #15438

Merged
merged 1 commit into from
Jul 24, 2017
Merged

bump(k8s.io/kubernetes): d2e5420de791a3a5234eb1c3d84921d68ae2b6d6 #15438

merged 1 commit into from
Jul 24, 2017

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Jul 24, 2017

@openshift-merge-robot openshift-merge-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jul 24, 2017
@openshift-merge-robot
Copy link
Contributor

Labelling this PR as size/XXL

@deads2k
Copy link
Contributor Author

deads2k commented Jul 24, 2017

merging as marker.

@deads2k deads2k merged commit 49df2d6 into openshift:master Jul 24, 2017
@deads2k
Copy link
Contributor Author

deads2k commented Jul 24, 2017

@mfojtik alright, the upstream fork is now up to date with the openshift code so you can generate the new clients there.

@deads2k
Copy link
Contributor Author

deads2k commented Jul 24, 2017

@sttts side comment. Can you see a reasonable way to regenerated the kube clients in openshift without dropping back to the fork? That would be nice.

@mfojtik
Copy link
Contributor

mfojtik commented Jul 24, 2017

@deads2k does this accommodate all moves i did in #15427 ?

@deads2k
Copy link
Contributor Author

deads2k commented Jul 24, 2017

@deads2k does this accommodate all moves i did in #15427 ?

No. It gives you a base to create your fork from though in openshift/kubernetes

@sttts
Copy link
Contributor

sttts commented Jul 25, 2017

Can you see a reasonable way to regenerated the kube clients in openshift without dropping back to the fork? That would be nice.

I don't see any bigger problem with that, at worst a a two digit number of bash code.

@deads2k deads2k deleted the move-upstream-06 branch August 3, 2017 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@deads2k @openshift-merge-robot @mfojtik @sttts