Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix panic when tag is nil when creating istag #15523

Closed
wants to merge 1 commit into from
Closed

Fix panic when tag is nil when creating istag #15523

wants to merge 1 commit into from

Conversation

soltysh
Copy link
Contributor

@soltysh soltysh commented Jul 28, 2017

@mfojtik ptal

@openshift-merge-robot openshift-merge-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 28, 2017
@openshift-merge-robot openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2017
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 28, 2017 •
edited
Loading

@soltysh: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/unit 1d0f8f8 link /test unit
ci/openshift-jenkins/extended_conformance_gce 1d0f8f8 link /test extended_conformance_gce
ci/openshift-jenkins/integration 1d0f8f8 link /test integration

Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mfojtik
Copy link
Contributor

mfojtik commented Jul 28, 2017

/approve no-issue
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 28, 2017
@openshift-merge-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mfojtik, soltysh

Associated issue requirement bypassed by: mfojtik

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@mfojtik
Copy link
Contributor

mfojtik commented Jul 28, 2017

@soltysh compilation failure: pkg/image/registry/imagestreamtag/rest_test.go:537: too many arguments in call to storage.Create

@smarterclayton smarterclayton modified the milestone: 3.6.0 Jul 28, 2017
@smarterclayton
Copy link
Contributor

I need this fixed if it is going to merge today

@openshift-merge-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mfojtik, soltysh

Associated issue requirement bypassed by: mfojtik

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@smarterclayton smarterclayton mentioned this pull request Jul 28, 2017
Merged
@smarterclayton
Copy link
Contributor

Moving to #15541 which has the test fixed

openshift-merge-robot added a commit that referenced this pull request Jul 29, 2017
@openshift-merge-robot
Merge pull request #15541 from smarterclayton/panic_nil
7dfcee7 
Automatic merge from submit-queue

Fix panic when tag is nil when creating istag

Replaces #15523 which has a compilation failure
@soltysh soltysh deleted the istag_panic_3.6 branch August 3, 2017 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mfojtik mfojtik

@smarterclayton smarterclayton

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. priority/P0 queue/critical-fix retest-not-required size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
3.6.0
Development

Successfully merging this pull request may close these issues.
5 participants
@soltysh @openshift-ci-robot @mfojtik @openshift-merge-robot @smarterclayton