Changing from no-cert to edge encryption should not panic #15550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-merge-robot
added
the
size/M
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: smarterclayton Associated issue: 15547 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
openshift-merge-robot
added
the
approved
The new route permission checks were too aggressive, erroring out if the user was attempting to clear route certificates, or panicking if setting a new TLS struct. Fix the conditions to be clearer, and add a test to guard the new edge cases.
Release image does not contain this and an upstream bug is blocking regeneration of the images due to bad tito dependencies. Change the ordering of the makefile and the release image to make failures easier to work around.
|
Merging to enable the 3.6.0 origin release. Will do follow ups in this and other branches. |
|
Automatic merge from submit-queue |
|
lgtm |
1 similar comment
|
lgtm |
|
Thanks for review
…On Mon, Jul 31, 2017 at 2:13 PM, Rajat Chopra ***@***.***> wrote:
lgtm
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#15550 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABG_py_TygxvELJy4mayWmtYklZepKzeks5sThkwgaJpZM4Ont0a>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A user who doesn't have permission to change from no cert to edge on an update should not be able to cause a panic. In addition, it should be possible for an unprivileged user to strip certificate info out of a previously valid route. Add better tests.
Fixes #15547
Also fixes the broken goversioninfo which prevented a 3.6.0 release build.