Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.6.x: UPSTREAM: 49992: Correctly handle empty watch event cache #15616

Merged
merged 1 commit into from
Aug 24, 2017
Merged

3.6.x: UPSTREAM: 49992: Correctly handle empty watch event cache #15616

merged 1 commit into from
Aug 24, 2017

Conversation

liggitt
Copy link
Contributor

@liggitt liggitt commented Aug 2, 2017

pick of #15614

@liggitt liggitt added this to the 3.6.x milestone Aug 2, 2017
@openshift-merge-robot openshift-merge-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Aug 2, 2017
@openshift-merge-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

No associated issue. Update pull-request body to add a reference to an issue, or get approval with /approve no-issue

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 2, 2017
@liggitt
Copy link
Contributor Author

liggitt commented Aug 3, 2017

weird router build failure
/retest

@liggitt
Copy link
Contributor Author

liggitt commented Aug 3, 2017

make: *** No rule to make target `build-router-e2e-test'.  Stop.

@stevekuznetsov - why are the 3.6 jobs trying to run things only found in the makefile on master?

@stevekuznetsov
Copy link
Contributor

@deads2k you need to backport your changes to 3.6

@liggitt
Copy link
Contributor Author

liggitt commented Aug 3, 2017

@deads2k you need to backport your changes to 3.6

that's not right... we should have a 3.6 job that is not affected by changes made to master CI

@stevekuznetsov
Copy link
Contributor

@liggitt yes, that would be a perfect world. We don't live in that world today

@liggitt liggitt changed the title UPSTREAM: 49992: Correctly handle empty watch event cache 3.6.x : UPSTREAM: 49992: Correctly handle empty watch event cache Aug 7, 2017
@liggitt liggitt changed the title 3.6.x : UPSTREAM: 49992: Correctly handle empty watch event cache 3.6.x: UPSTREAM: 49992: Correctly handle empty watch event cache Aug 7, 2017
@liggitt
Copy link
Contributor Author

liggitt commented Aug 18, 2017

/retest

@liggitt liggitt added the lgtm Indicates that a PR is ready to be merged. label Aug 24, 2017
@liggitt
Copy link
Contributor Author

liggitt commented Aug 24, 2017

parent is merged

@openshift-merge-robot
Copy link
Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 24, 2017

@liggitt: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/extended_conformance_gce 773e73f link /test extended_conformance_gce

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue

@openshift-merge-robot openshift-merge-robot merged commit 60e01e9 into openshift:release-3.6 Aug 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants