-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert back to the "normal" apiserver authentication #15739
Revert back to the "normal" apiserver authentication #15739
Conversation
61af87a
to
950b29c
Compare
@deads2k the PR this was blocked on has been closed, what's the latest status? |
…n is on by default" This reverts commit a564e15.
950b29c
to
7b09621
Compare
@bparees rebased |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bparees, deads2k The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
/retest |
1 similar comment
/retest |
@bparees @jim-minter can you guys put the test back to the way I initially built it, where the daemonset and service were located in the namespace that the ansible installer was going to lay them into? Alternatively, you can try to wire your roles up properly. |
@deads2k openshift/openshift-ansible#5056 has closed, is this still blocked on anything? |
/retest |
/test all |
@deads2k i'm still not clear on if anything is holding this up and/or if there are still test changes that need(or should) to go with this |
Nothing needed for 3.7. |
talked to @deads2k and this is failing for reasons that are unclear w/o being able to get TSB logs. we're hoping that once @jim-minter's work to use the cluster-wide TSB installed by ansible, in extended tests, it will be easier to get the right logs to see why this is failing. (@deads2k contends that the TSB is crashing, and i'm not sure it'll be any easier to get the logs if that's true, but i guess we'll cross that bridge when we get to it). in the meantime: |
also to follow up on the request to revert the TSB tests: At some point @deads2k wrote the TSB tests to share an TSB installed at the cluster level (which would align w/ how things will work once @jim-minter's effort to get us using the ansible installed TSB lands). At some future point, the tests were reworked to use a TSB instance per test. I do not recall the change or the reasoning for it, though I do recall a number of flakes in the tests and some iteration to resolve them. In any case, once @jim-minter's change lands to be able to use the ansible installed TSB, we will be changing the tests back to not using their own TSB, so @deads2k will get his wish. @deads2k also expressed concern that when we go to a single TSB, our tests may start conflicting. I think we're safe from that since our tests do not manipulate the catalog, and everything they do do is done in a test-scoped namespace (provision/deprovision). But if we ever did introduce tests that need to register new templates(or worse, de-register some), or change which namespaces the TSB monitors for templates to offer in the catalog, we'll need to keep that concern in mind. |
/retest |
/test all |
bump bot |
/test all [submit-queue is verifying that this PR is safe to merge] |
Automatic merge from submit-queue (batch tested with PRs 15739, 18060). |
@deads2k: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Blocked on openshift/openshift-ansible#5056