extended: Skip test instead of failing #15779
Conversation
When server configuration cannot be determined. Signed-off-by: Michal Minář <[email protected]>
openshift-merge-robot
added
the
size/S
|
/test extended_image_registry |
| @@ -309,7 +313,7 @@ func bumpLimit(oc *exutil.CLI, resourceName kapi.ResourceName, limit string) (ka | |||
| func getMaxImagesBulkImportedPerRepository() (int, error) { | |||
There was a problem hiding this comment.
Is there any way to get at this from a client?
There was a problem hiding this comment.
No. It's in the master's configuration file. The value needs to be passed down to the test.
|
Only concern is nobody will run this test now |
@stevekuznetsov I'd like to export this variable in origin_built_installed_release.yml and propagate that to test_pull_request_origin_extended_image_registry.yml. Until that happens, we can skip it. |
|
@miminar yeah, if there is a flag on OpenShift-Ansible that is passing this through we should use that to configure it and export the var there as well. /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: miminar, stevekuznetsov The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
openshift-merge-robot
added
the
approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Ignoring the should or shouldn't aspect of this, it seems like a good candidate for retest-not-required. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
@miminar: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/test extended_image_registry |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue |
When server configuration cannot be determined.
When the extended test is run with
TEST_ONLY=true(the origin cluster isexpected to be configured and run separately), some environment variables do
not get exported to extended test binary. Let's skip test requiring them.