Split up SDN master/node/proxy/CNI code #15781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-merge-robot
added
the
size/L
|
Looks clean to me. Squash the commits maybe to a recent date. A minor point that came up in my head: |
openshift-merge-robot
added
the
needs-rebase
danwinship
force-pushed
the
split-master-node
branch
from
b9b597d to
49f767c
Compare
openshift-merge-robot
removed
the
needs-rebase
|
/test extended_conformance_gce |
openshift-merge-robot
added
the
needs-rebase
|
LGTM |
danwinship
force-pushed
the
split-master-node
branch
from
49f767c to
7ecb3e9
Compare
openshift-merge-robot
removed
the
needs-rebase
danwinship
force-pushed
the
split-master-node
branch
from
7ecb3e9 to
7a4ed1d
Compare
|
/retest |
knobunc
approved these changes
Aug 25, 2017
|
I will say the right incantation on Monday to allow it to merge :-) |
openshift-merge-robot
added
the
needs-rebase
danwinship
force-pushed
the
split-master-node
branch
from
7a4ed1d to
4570e27
Compare
openshift-merge-robot
removed
the
needs-rebase
|
flake #15969 |
|
/lgtm |
|
/lgtm |
|
/approve
On Aug 29, 2017, at 12:57 PM, OpenShift Merge Robot < [email protected]> wrote:
[APPROVALNOTIFIER] This PR is *NOT APPROVED*
This pull-request has been approved by: *danwinship
<#15781#>*, *knobunc
<#15781 (comment)>*,
*pravisankar
<#15781 (comment)>*
We suggest the following additional approver: *smarterclayton*
Assign the PR to them by writing /assign @smarterclayton in a comment when
ready.
The full list of commands accepted by this bot can be found here
<https://github.com/kubernetes/test-infra/blob/master/commands.md>.
Needs approval from an approver in each of these OWNERS Files:
- *hack/lib/OWNERS
<https://github.com/openshift/origin/blob/master/hack/lib/OWNERS>*
- *pkg/cmd/OWNERS
<https://github.com/openshift/origin/blob/master/pkg/cmd/OWNERS>*
- pkg/sdn/OWNERS
<https://github.com/openshift/origin/blob/master/pkg/sdn/OWNERS>
[danwinship,knobunc,pravisankar]
You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#15781 (comment)>,
or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABG_p8-K83CukP07WxJG0v7Sb80l6Gviks5sdEMAgaJpZM4O3wVH>
.
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danwinship, knobunc, pravisankar, smarterclayton The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
openshift-merge-robot
added
the
approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/test extended_conformance_install_update |
|
/retest |
|
Automatic merge from submit-queue (batch tested with PRs 15862, 15781, 15944) |
openshift-merge-robot
added a commit
that referenced
this pull request
Aug 31, 2017
Automatic merge from submit-queue (batch tested with PRs 16054, 16057, 15440, 16028, 16055) Rename pkg/sdn to pkg/network, for consistency with its API @deads2k wanted this This is on top of #15781, but that should be merged soon. Only the last two commits ("Rename pkg/sdn to pkg/network, for consistency with its API" and "Regenerate files") are for this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now
pkg/sdn/pluginis a mix of code that runs on the master and code that runs on nodes. This splits things up. I think it makes sense? @openshift/networking what do you think?This gets rid of the
pkg/sdn/plugindirectory completely; node-specific code is now inpkg/sdn/nodebecause it doesn't actually use the network plugin API at all any more.