UPSTREAM: 50934: Skip non-update endpoint updates #15889
Conversation
openshift-merge-robot
added
the
size/L
|
/lgm |
openshift-merge-robot
added
the
approved
|
/test extended_conformance_gce |
|
I'll look in the morning to see if the failure is a flake or legitimate. But in case it's a flake, I'm running it again. |
|
/test extended_conformance_gce |
|
Flake #15941 |
|
/retest also @derekwaynecarr misspelled "lgtm" in the bot message 😛 |
|
Did we decide to leave this unmerged for now? I thought that maybe we had decided to keep it off of the 3.6 branch until it had more soak time upstream and in master, so maybe it's good that he misspelled "lgtm". That being said, I am interested in seeing what impact this has on https://bugzilla.redhat.com/show_bug.cgi?id=1481603 and we won't really know until the OpenShift Online free tier gets a 3.6 update with this in it (or when they go to 3.7). |
|
@joelsmith ah indeed. So many of these 3.6 PRs; got a little punchy 😄 Wonder if bot understands Waiting on master and upstream kube soak before including in 3.6 @derekwaynecarr @smarterclayton how long we want to let this soak? Are we pushing this to 3.6.2+? |
|
/retest |
|
/lgtm |
|
@sjenning: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: derekwaynecarr, sjenning The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
integration test seems to be doing better now. still flaking but not every time now. |
|
waiting for #16336 to fix integration test |
|
hopefully now that #16336 is merged, the test will pass. |
|
Automatic merge from submit-queue |
xref kubernetes/kubernetes#50934 and kubernetes/kubernetes#51144
master PR:
#15888
xref https://bugzilla.redhat.com/show_bug.cgi?id=1481603
@joelsmith @derekwaynecarr @eparis @smarterclayton