Make focus and skip a lot easier to use in extended tests

[smarterclayton]

Generates synthetic suites more effectively by actually modifying the test name based on the filter. This means that ginkgo -focus -dryRun only prints the tests it will actually run.

Now:

ginkgo ... -focus=Suite:openshift/conformance/parallel
ginkgo ... -focus=Suite:openshift/conformance/serial

Both

ginkgo ... -focus=Suite:openshift/conformance

OpenShift

ginkgo ... -focus=Suite:openshift

Kubernetes

ginkgo ... -focus=Suite:k8s

@stevekuznetsov @bparees I think this is easier to reason about

[openshift-merge-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smarterclayton

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

• OWNERS [smarterclayton]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

[bparees]

if you're doing this, can't the synthetic suite stuff go away and we'll just pass the focus instead? or you want to be able to combine the "suite" focus with custom focuses?

[smarterclayton]

We can't drop the old without changing all the jobs, so there's some period of overlap.

…

On Tue, Aug 22, 2017 at 11:14 PM, Ben Parees ***@***.***> wrote: if you're doing this, can't the synthetic suite stuff go away and we'll just pass the focus instead? or you want to be able to combine the "suite" focus with custom focuses? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#15915 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABG_pzf7l3Z1fk37hMppscZMwJtn_lGHks5sa5kHgaJpZM4O_Y7z> .

[smarterclayton]

I find it easier to read working from broad to specific. All the other ways to write the case seemed to make it harder to read. It doesn't help that serial vs not should really be a non issue (I want to propose to ginkgo at some point). On Aug 23, 2017, at 9:52 PM, Steve Kuznetsov <[email protected]> wrote: *@stevekuznetsov* commented on this pull request. ------------------------------ In test/extended/util/test.go <#15915 (comment)>:

@@ -113,6 +114,30 @@ func ExecuteTest(t *testing.T, suite string) {

r = append(r, reporters.NewJUnitReporter(path.Join(reportDir, fmt.Sprintf("%s_%02d.xml", reportFileName, config.GinkgoConfig.ParallelNode)))) } + ginkgo.WalkTests(func(name string, node types.TestNode) { + if !excludedTestsFilter.MatchString(name) { + parallel := parallelConformanceTestsFilter.MatchString(name) + serial := serialConformanceTestsFilter.MatchString(name) + switch { + case !serial && !parallel: + // do nothing + case serial: + if !strings.Contains(name, "[Serial]") { + node.SetText(node.Text() + " [Serial]") + } + node.SetText(node.Text() + " [Suite:openshift/conformance/serial]") + default: I know it's technically correct but it just seemed very roundabout — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#15915 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABG_p6xu2HJgfg0qOH16dUE__HozCTXyks5sbNd2gaJpZM4O_Y7z> .

[stevekuznetsov]

Can we break out the feature rename so it can merge quickly?

[smarterclayton]

No rush on the rename really. The change I gave you was backwards compatible.

…

On Tue, Sep 12, 2017 at 11:50 AM, Steve Kuznetsov ***@***.***> wrote: Can we break out the feature rename so it can merge quickly? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#15915 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABG_pw32dxdWb9X9W89qylCPTXmS7AJuks5shqhSgaJpZM4O_Y7z> .

[smarterclayton]

/retest

[smarterclayton]

/retest

[smarterclayton]

/retest

[smarterclayton]

/retest

[smarterclayton]

Merging, for the love of god

[openshift-merge-robot]

Automatic merge from submit-queue