Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: use generated clientset for deployment controllers and add expansion for instantiate #15981

Closed
wants to merge 2 commits into from
Closed

WIP: use generated clientset for deployment controllers and add expansion for instantiate #15981

wants to merge 2 commits into from

Conversation

mfojtik
Copy link
Contributor

@mfojtik mfojtik commented Aug 25, 2017

No description provided.

@openshift-merge-robot openshift-merge-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 25, 2017
@openshift-merge-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mfojtik

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 25, 2017
@mfojtik
Copy link
Contributor Author

mfojtik commented Aug 25, 2017

@deads2k @smarterclayton PTAL

I tested this and it seems like we can add missing methods via expansion. (i need to plumb tests && stuff but want to get agreement that expansions is the right way to do this... )

@openshift-merge-robot openshift-merge-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 25, 2017
enj
enj reviewed Aug 25, 2017
View reviewed changes
Copy link
Contributor

@enj enj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable but I am not familiar enough with the generated code to lgtm.

pkg/deploy/generated/internalclientset/typed/apps/internalversion/generated_expansion.go
@@ -1,3 +1 @@
package internalversion
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete this file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, clientgen will recreate it :-) without interface...

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 25, 2017 •
edited
Loading

@mfojtik: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/unit 099f5ee link /test unit

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot
Copy link
Contributor

@mfojtik PR needs rebase

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 28, 2017
@mfojtik
Copy link
Contributor Author

mfojtik commented Aug 29, 2017

closing this in favor of #16019

@mfojtik mfojtik closed this Aug 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enj enj enj left review comments

Assignees

@soltysh soltysh

@enj enj

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mfojtik @openshift-merge-robot @openshift-ci-robot @enj @soltysh