Validate pod's volumes only once and also fix field path in the error message #16006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-merge-robot
added
the
size/M
liggitt
reviewed
Aug 28, 2017
| @@ -269,6 +269,25 @@ func (s *simpleProvider) ValidatePodSecurityContext(pod *api.Pod, fldPath *field | |||
|
|
|||
| allErrs = append(allErrs, s.sysctlsStrategy.Validate(pod)...) | |||
|
|
|||
| // TODO(timstclair): ValidatePodSecurityContext should be renamed to ValidatePod since its scope | |||
|
lgtm with nit |
… message. This is the same change as kubernetes/kubernetes#31927 but for the SecurityContextConstraints.
php-coder
force-pushed
the
scc_volumes_error_message
branch
from
0cda30e to
81af0e1
Compare
|
PTAL @soltysh |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: php-coder, soltysh The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
openshift-merge-robot
added
the
approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
Automatic merge from submit-queue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same change as kubernetes/kubernetes#31927
but for the
SecurityContextConstraints.PTAL @liggitt @pweil-
CC @simo5